Skip to content

#8 Add test coverage for Sonar #2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matthoward366 wants to merge 111 commits into from
Closed

#8 Add test coverage for Sonar #2092

matthoward366 wants to merge 111 commits into from

Conversation

@matthoward366
Copy link
Member

@matthoward366 matthoward366 commented Aug 5, 2024

Fixes #8

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@matthoward366 matthoward366 force-pushed the mhoward-sonar-coverage branch from f6cd5c5 to 88d9f8c Compare August 5, 2024 19:24
matthoward366 and others added 29 commits August 5, 2024 15:33
@matthoward366
Add test coverage for Sonar
9108aff 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#1872 Use React Testing Library for Toolbar Tests (elyra-ai#1873
587bc77 
)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
More docs changes (elyra-ai#1871)
b76f387 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@nmgokhale @matthoward366
elyra-ai#1867 Fixed left nav subtabs CSS in tearsheet (elyra-ai#1875)
57b74b7 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
1878 Don't createRoot every time node data changes in SvgCanvasExtern…
811438d 
…al (elyra-ai#1879)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1876 'Cannot read properties of null' errors in console usin…
90a0156 
…g contex… (elyra-ai#1877)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@nmgokhale @matthoward366
elyra-ai#1881 Added Layer component at control level (elyra-ai#1882)
5dd3935 
Signed-off-by: Neha Gokhale <neha.gokhale@ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#1883 Fix Tooltips Test Harness Top Toolbar icons in v13 (ely…
cd23279 
…ra-ai#1885)

Signed-off-by: srikant <srksriks123@gmail.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@nmgokhale @matthoward366
elyra-ai#1886 Don't run jest tests while deploying test harness (elyr…
d2e2269 
…a-ai#1887)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@veenas1 @matthoward366
elyra-ai#1635 use Carbon RadioButtonGroup in RadiosetControl instead …
d4c814d 
…of custom grouping code (elyra-ai#1814)

Signed-off-by: Veena S <Veena.S1@ibm.com>
Co-authored-by: Matt Howard <matthoward366@users.noreply.github.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@JesusGuerrero @matthoward366
elyra-ai#1888 Enable HTML in Markdown (elyra-ai#1889)
08ba338 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#1646 Panel accordions are not using the carbon standards (el…
4110337 
…yra-ai#1648)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#1828 Resolve Cypress Test Issues (elyra-ai#1843)
13189ca 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1891 Enable multiple undo/redo button and panel (elyra-ai#1892)
50f9aae 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1893 New common-canvas documentation required (elyra-ai#1894)
67592a5 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
Fix image URLs in docs (elyra-ai#1898)
358c507 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1902 Comment text truncated in sample apps and canvas test f…
2b261d0 
…iles (elyra-ai#1903)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1891 Enable multiple undo/redo button and panel (elyra-ai#1904)
903b457 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@nmgokhale @matthoward366
elyra-ai#1912 Fix unit tests after @carbon/react 1.56.0 upgrade (elyr…
8a0055c 
…a-ai#1913)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1909 New common-canvas documentation required (part 2) (elyr…
c5e2e66 
…a-ai#1910)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@Paul-Kawalkowski @matthoward366
elyra-ai#1915 When publish 12.x versions add a tag to avoid defaultin…
007c838 
…g to `latest` (elyra-ai#1916)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1911 Add a Docs button to the test harness (elyra-ai#1914)
9a8d9a8 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1893 New common-canvas documentation required - toolbar (ely…
8356bdc 
…ra-ai#1917)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#1900 Use RTL in notification-panel tests (elyra-ai#1901)
58a805e 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1893 New common-canvas documentation required - node & comme…
e9e9037 
…nt custo… (elyra-ai#1921)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1923 Palette node tooltips not working in Tiny App (elyra-ai…
5b7d17a 
…#1926)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1893 New common-canvas documentation required - tidy up, new…
9de71d6 
… footer,… (elyra-ai#1929)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#1893 New common-canvas documentation required - supernodes c…
da85023 
…hange (elyra-ai#1930)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@Paul-Kawalkowski @matthoward366
elyra-ai#1925 Delta Translations (elyra-ai#1924)
316775c 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
tomlyn and others added 21 commits August 5, 2024 15:33
@tomlyn @matthoward366
elyra-ai#2051 With Ports link method new links are being drawn like f…
8e387bd 
…reeform (elyra-ai#2052)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@caritaou @matthoward366
elyra-ai#2057 Downgrade Carbon (elyra-ai#2059)
c707800 
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2053 Refactor display comments code to be like display nodes…
de45c47 
… code (elyra-ai#2054)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2055 enableStraightLinksAsFreeform set to false by default -…
21ef41f 
… should … (elyra-ai#2056)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@PRINCESANCHEZ @matthoward366
Improved visibility of sample apps (elyra-ai#2037)
0bdf578 
Signed-off-by: Prince Sanchez <prince.sanchez@ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#2030 Add readOnly control in Common Properties (elyra-ai#2032)
5c3ccf0 
Signed-off-by: srikant <srksriks123@gmail.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@veenas1 @matthoward366
elyra-ai#2066 RangeError when editing after validating incorrect expr…
df5ea23 
…ession (elyra-ai#2067)

Signed-off-by: Veena S <Veena.S1@ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#2062 Checkboxset in Common Properties should support helperT…
6eed500 
…ext (elyra-ai#2063)

Signed-off-by: srikant <srksriks123@gmail.com>
Co-authored-by: Matt Howard <matthoward366@users.noreply.github.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2064 Enable new Comment type which supports a WYSIWYG editor (…
c8050e8 
…elyra-ai#2065)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2070 Chevron positioned incorrectly in context menu with icon (
4147463 
elyra-ai#2071)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
2072 Use of createRoot causing errors with React 17 (elyra-ai#2073)
cada69a 
Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#2068 Change background Color for Dropdown and Table Search i…
554f37a 
…n Tearsheet (elyra-ai#2069)

Signed-off-by: srikant <srksriks123@gmail.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@mikieyx @matthoward366
elyra-ai#2049 Use React Testing Library for common-properties tests -…
f84ce5f 
… Part 1 - Components (elyra-ai#2050)

Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@srikant-ch5 @matthoward366
elyra-ai#2060 Open Expression Editor in a Tearsheet. (elyra-ai#2061)
5f83ae5 
Signed-off-by: srikant <srksriks123@gmail.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2074 Text toolbar dropdown menus not fully displayed when to…
be3409d 
…olbar ne… (elyra-ai#2075)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2076 Document that a ibm plex scss should be included when b…
de2d3d0 
…uilding … (elyra-ai#2077)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2064 Fix outline-solid (elyra-ai#2078)
f6a53f8 
Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2079 Add ability to adjust position of context toolbar for l…
fea54d7 
…inks (elyra-ai#2080)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2083 With WYSIWYG comments IBM Plex Condensed font display i…
abd4be5 
…ncorrectly (elyra-ai#2084)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@tomlyn @matthoward366
elyra-ai#2085 Page crashes when mousing over node while submenu toolb…
c1b1de0 
…aritem i… (elyra-ai#2086)

Signed-off-by: CTomlyn <tomlyn@us.ibm.com>
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@matthoward366
Fix secret
237f8ac 
Signed-off-by: Matt Howard <mwhoward@us.ibm.com>
@matthoward366 matthoward366 force-pushed the mhoward-sonar-coverage branch from 08c05ac to 237f8ac Compare August 5, 2024 20:34
@matthoward366 matthoward366 deleted the mhoward-sonar-coverage branch August 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Sonar to builds for tracking code bugs and code coverage

10 participants

@matthoward366 @srikant-ch5 @tomlyn @nmgokhale @veenas1 @JesusGuerrero @Paul-Kawalkowski @mikieyx @caritaou @PRINCESANCHEZ